Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Sep 15, 2025

WOOMOB-1340

Description

  • Integrates new garden related fields introduced for Sites endpoint in the PR.
  • Updates CIABEligibilityChecker by removing the temp mock logic with the relevant logic based on new "Garden" fields in Site model.
  • The new logic now checks if the is_garden field is true and the garden_name equals to "commerce" to determine the CIAB environment.
  • Adds tests for CIABEligibilityChecker basing on the new logic.

Note: the majority of changes in the diff are introduced by the new 126th data model version.

Non-CIAB site smoke test

  • Login into our shared testing site or your personal site that wasn't created by the Garden API demo tool.
  • The easiest way to verify the existing CIAB/non-CIAB behaviour is check if "Payments" and "Blaze" options are presented in "Menu".
  • So navigate to Menu in bottom tab.
  • Make sure Payments and Blaze options are presented.

CIAB site testing steps

  • Use the Garden API demo tool. and create a testing Garden based site.
  • Login into the site with your wp.com account using the "W" logo in web tool
  • Login into the site on mobile app
  • Repeat the checking step from the Non-CIAB site smoke test, i.e. navigate to the Menu and make sure "Blaze" and "Payments" are hidden.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.3 milestone Sep 15, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 15, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 15, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16131-2d79238
Version23.2
Bundle IDcom.automattic.alpha.woocommerce
Commit2d79238
Installation URL6vdea8s0m96v8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@RafaelKayumov RafaelKayumov marked this pull request as ready for review September 15, 2025 18:53
@itsmeichigo itsmeichigo self-assigned this Sep 16, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

Please also update MIGRATIONS.md file and add a migration test for the new model version.

@RafaelKayumov
Copy link
Contributor Author

Works as expected 👍

Please also update MIGRATIONS.md file and add a migration test for the new model version.

Right

@RafaelKayumov RafaelKayumov merged commit 42063c4 into trunk Sep 16, 2025
14 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1340-integrate-garden-site-api-fields branch September 16, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants